Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OidcBackChannelLogoutTokenValidator should not throw an NPE when issuer is missing #15771

Closed
jzheaux opened this issue Sep 9, 2024 · 2 comments · Fixed by #15824
Closed

OidcBackChannelLogoutTokenValidator should not throw an NPE when issuer is missing #15771

jzheaux opened this issue Sep 9, 2024 · 2 comments · Fixed by #15824
Assignees
@jzheaux @wapkch
Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: bug A general bug
Milestone
6.2.x

Comments

@jzheaux
Copy link
Contributor

jzheaux commented Sep 9, 2024 •
edited
Loading

Related to spring-projects/spring-boot#42172 (comment), when ClientRegistration does not have an issuerUri configured, it should give a better error than an NPE.

This needs to be addressed for both the imperative and reactive versions of the class.

Please base this change off the 6.2.x branch so it can be forward-ported when merged.
@jzheaux jzheaux added status: waiting-for-triage An issue we've not yet triaged type: bug A general bug status: ideal-for-contribution An issue that we actively are looking for someone to help us with in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) and removed status: waiting-for-triage An issue we've not yet triaged labels Sep 9, 2024
@jzheaux jzheaux added this to the 6.2.x milestone Sep 9, 2024
@jzheaux jzheaux mentioned this issue Sep 9, 2024
Open
@wapkch
Copy link

wapkch commented Sep 13, 2024

Hi @jzheaux , may i work on this?

@jzheaux jzheaux removed the status: ideal-for-contribution An issue that we actively are looking for someone to help us with label Sep 17, 2024
@jzheaux
Copy link
Contributor Author

jzheaux commented Sep 17, 2024

Yes, please. :) Thanks for offering, the issue is yours.

wapkch pushed a commit to wapkch/spring-security that referenced this issue Sep 18, 2024
Fix NPE in OidcBackChannelLogoutTokenValidator when OIDC Provider Iss…
5161d96 
…uer is missing

Closes spring-projectsgh-15771
@wapkch wapkch mentioned this issue Sep 18, 2024
Merged
jzheaux pushed a commit to wapkch/spring-security that referenced this issue Sep 23, 2024
@jzheaux
Improve OidcBackChannelLogoutTokenValidator error when provider issue…
9289f22 
…r is missing

Closes spring-projectsgh-15771
jzheaux added a commit to wapkch/spring-security that referenced this issue Sep 23, 2024
@jzheaux
Fix Formatting
93fd363 
Issue spring-projectsgh-15771
jzheaux added a commit that referenced this issue Sep 30, 2024
@jzheaux
Fix Formatting
c1857c0 
Issue gh-15771
@jzheaux jzheaux mentioned this issue Sep 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jzheaux jzheaux

@wapkch wapkch

Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: bug A general bug
Projects
None yet
Milestone
6.2.x
2 participants
@jzheaux @wapkch