Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document BearerTokenResolver in reference #6254

Closed
jgrandja opened this issue Dec 7, 2018 · 3 comments
Closed

Document BearerTokenResolver in reference #6254

jgrandja opened this issue Dec 7, 2018 · 3 comments
Assignees
Labels
in: docs An issue in Documentation or samples type: enhancement A general enhancement
Milestone

Comments

@jgrandja
Copy link
Contributor

jgrandja commented Dec 7, 2018

There is no documentation for BearerTokenResolver and it's default implementation DefaultBearerTokenResolver in the reference. We should document and provide code samples on how to use and customize.

@jgrandja jgrandja added this to the 5.2.0.M1 milestone Dec 7, 2018
@jgrandja jgrandja added in: docs An issue in Documentation or samples in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) labels Dec 7, 2018
@rwinch rwinch modified the milestones: 5.2.0.M1, 5.2.0.M2 Jan 16, 2019
@jgrandja jgrandja modified the milestones: 5.2.0.M2, 5.2.0.RC1 Apr 15, 2019
@eleftherias eleftherias modified the milestones: 5.2.0.M3, 5.2.0.RC1 Jun 14, 2019
@jzheaux jzheaux modified the milestones: 5.2.0.M4, 5.2.0.RC1 Aug 5, 2019
@kostya05983
Copy link
Contributor

Hello @jgrandja , I can take this one, If I understand correctly, I should add docs in docs module of spring security, shouldn't I? And where can I put code samples of this?

@jzheaux jzheaux assigned jzheaux and unassigned jzheaux Aug 10, 2019
@jzheaux
Copy link
Contributor

jzheaux commented Aug 10, 2019

@kostya05983 Thanks for volunteering - yes, you'd place docs in the docs module.

As for a sample, you could add one that goes alongside the other oauth2resourceserver samples, though there are quite a few already. Unless you feel customizing a bearer token resolver to be quite nuanced, I'd lean towards just sticking with snippets in the documentation.

Does that sound doable?

@jzheaux jzheaux added type: enhancement A general enhancement and removed in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) labels Aug 10, 2019
@kostya05983
Copy link
Contributor

@jgrandja , thanks for guide, yes, it do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: docs An issue in Documentation or samples type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

5 participants