Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ISSUE-11725] Add secondary statusCode messages on error #14743

Merged
merged 5 commits into from
Mar 22, 2024
Merged

[ISSUE-11725] Add secondary statusCode messages on error #14743

merged 5 commits into from
Mar 22, 2024

Conversation

youngkih
Copy link
Contributor

This fixes #11725 and reflects the feedback from #12818

@pivotal-cla
Copy link

@youngkih Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-cla
Copy link

@youngkih Thank you for signing the Contributor License Agreement!

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Mar 13, 2024
@youngkih youngkih mentioned this pull request Mar 13, 2024
Closed
@sjohnr sjohnr added in: saml2 An issue in SAML2 modules type: enhancement A general enhancement labels Mar 14, 2024
jzheaux
jzheaux requested changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@jzheaux jzheaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @youngkih! I've left some feedback inline.

...ramework/security/saml2/provider/service/authentication/OpenSaml4AuthenticationProvider.java Outdated Show resolved Hide resolved
...ramework/security/saml2/provider/service/authentication/OpenSaml4AuthenticationProvider.java Outdated Show resolved Hide resolved
...ramework/security/saml2/provider/service/authentication/OpenSaml4AuthenticationProvider.java Show resolved Hide resolved
...ork/security/saml2/provider/service/authentication/OpenSaml4AuthenticationProviderTests.java Show resolved Hide resolved
...ork/security/saml2/provider/service/authentication/OpenSaml4AuthenticationProviderTests.java Outdated Show resolved Hide resolved
@jzheaux jzheaux removed the status: waiting-for-triage An issue we've not yet triaged label Mar 21, 2024
@youngkih youngkih requested a review from jzheaux March 21, 2024 14:57
@jzheaux jzheaux merged commit 6e45e65 into spring-projects:main Mar 22, 2024
3 checks passed
@jzheaux jzheaux added this to the 6.3.0-RC1 milestone Mar 22, 2024
@jzheaux
Copy link
Contributor

jzheaux commented Mar 22, 2024

Thanks, @youngkih! This is now merged into main. I also added a polish commit to make the code style a bit more consistent with the rest of Spring Security.

@youngkih
Copy link
Contributor Author

Cool, thanks @jzheaux !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jzheaux jzheaux jzheaux approved these changes

Assignees

@jzheaux jzheaux

Labels
in: saml2 An issue in SAML2 modules type: enhancement A general enhancement
Projects
None yet
Milestone
6.3.0-RC1
Development

Successfully merging this pull request may close these issues.

OpenSaml4AuthenticationProvider should include secondary statusCode messages on error
5 participants
@youngkih @pivotal-cla @jzheaux @sjohnr @spring-projects-issues