Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes using
@AuthorizeReturnObject
practical on a more diverse set of classes and interfaces, including Spring Data interfaces.A typical Spring Data interface begins like this:
and because
CrudRepository
has methods that return primitive types likeint count()
, an application cannot use@AuthorizeReturnObject
at the class level.This is a reasonable default since the semantics around Spring Security method security annotations are that placing it at the class level is functionally equivalent to placing it on the method level. Since it would be an error to use
@AuthorizeReturnObject
on a method that returns anint
, we want to error by default.With this PR, an application can relax that behavior by doing:
It incidentally introduces an inner interface
AuthorizationAdvisorProxyFactory.TargetVisitor
to simplify any kind of proxy customization of the target object.The reason I like this approach is that it gives folks more power to customize how a given type is handled. The alternative is to not use
@EnableMethodSecurity
so that they can publish their ownAuthorizationProxyFactory
or possibly add a bean factory post-processor to inject their own authorization proxy factory implementation.Here are some simple examples other than ignoring a type are to use different
ProxyFactory
settings or to programmatically visit an object:Issue gh-14597