Simplification of creation of OAuth2TokenValidator with JwtValidators defaults. #14832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
jzheaux
added
type: enhancement
jzheaux
requested changes
Apr 2, 2024
There was a problem hiding this comment.
Thanks, @CrazyParanoid for the quick PR! I've left some feedback inline. Will you also please make the commit message title shorter so that it doesn't wrap in IDEs? Additional information can be placed in the description section like so:
Add JwtValidators Append To Default
A description here about what was done whose description
also wraps so that it is easier to read
Closes gh-14831
...framework/security/oauth2/client/oidc/authentication/DefaultOidcIdTokenValidatorFactory.java
Outdated
Show resolved
Hide resolved
oauth2/oauth2-jose/src/main/java/org/springframework/security/oauth2/jwt/JwtValidators.java
Show resolved
Hide resolved
Implemented simplified creation of default OAuth2TokenValidator with additional validators. Closes spring-projectsgh-14831
franticticktick
force-pushed
the
gh-14831
branch
from
94ad641 to
27f4dcb
Compare
|
Hi @jzheaux ! Thanks for your feedback! All your comments have been resolved. |
jzheaux
approved these changes
Apr 2, 2024
|
Thanks, @CrazyParanoid! This is now merged into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplification of creation of OAuth2TokenValidator with JwtValidators defaults.
Closes gh-14831