Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove useBase64 parameter #14862

Merged
merged 1 commit into from
Apr 26, 2024
Merged

Remove useBase64 parameter #14862

merged 1 commit into from
Apr 26, 2024

Conversation

sheriumair
Copy link
Contributor

This PR removes the 'useBase64' parameter from createPasswordEncoderBeanDefinition. It's no longer needed, simplifying the function's interface and ensuring consistency. The PR also removed false from createPasswordEncoderBeanDefinition method call.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Apr 7, 2024
@sheriumair
Copy link
Contributor Author

Hey, any update on this PR?

jzheaux
jzheaux requested changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@jzheaux jzheaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @sheriumair! I've left some feedback inline.

.../src/main/java/org/springframework/security/config/authentication/PasswordEncoderParser.java Show resolved Hide resolved
@jzheaux jzheaux self-assigned this Apr 18, 2024
@jzheaux jzheaux added in: config An issue in spring-security-config type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged labels Apr 18, 2024
@sheriumair sheriumair requested a review from jzheaux April 26, 2024 10:51
@jzheaux jzheaux changed the title Removed useBase64 parameter Remove useBase64 parameter Apr 26, 2024
@jzheaux jzheaux force-pushed the remove-useBase64-parameter branch from 15ab5b8 to 06f33c6 Compare April 26, 2024 22:53
@jzheaux jzheaux changed the base branch from main to 5.8.x April 26, 2024 22:54
@jzheaux jzheaux added this to the 5.8.13 milestone Apr 26, 2024
@jzheaux jzheaux merged commit 0e21138 into spring-projects:5.8.x Apr 26, 2024
3 checks passed
@jzheaux
Copy link
Contributor

jzheaux commented Apr 26, 2024

Thanks, @sheriumair! This is now merged into 5.8.x, 6.1.x, 6.2.x, and main.

@sjohnr sjohnr added type: enhancement A general enhancement and removed type: task A general task labels May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jzheaux jzheaux jzheaux approved these changes

Assignees

@jzheaux jzheaux

Labels
in: config An issue in spring-security-config type: enhancement A general enhancement
Projects
None yet
Milestone
5.8.13
Development

Successfully merging this pull request may close these issues.
4 participants
@sheriumair @jzheaux @sjohnr @spring-projects-issues