Add timeout defaults to JwtDecoders #14890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MrJovanovic13 Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@MrJovanovic13 Thank you for signing the Contributor License Agreement! |
spring-projects-issues
added
the
status: waiting-for-triage
jzheaux
requested changes
Apr 17, 2024
There was a problem hiding this comment.
Thanks, @MrJovanovic13, for the PR! In addition to my inline feedback, will you also please update your commit message to be formatted like so:
Add Default Timeout to JwtDecoders RestTemplate
Any other description you'd like to add that wraps roughly at 60
characters
Closes gh-14269
In this way, it causes the automation to close the related ticket and the short title also makes it easy to browse in IDEs.
.../main/java/org/springframework/security/oauth2/jwt/JwtDecoderProviderConfigurationUtils.java
Show resolved
Hide resolved
oauth2/oauth2-jose/src/main/java/org/springframework/security/oauth2/jwt/NimbusJwtDecoder.java
Outdated
Show resolved
Hide resolved
jzheaux
added
type: enhancement
jzheaux
changed the title
|
Thanks for the comments, I have resolved both of them now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds reasonable timeouts to JwtDecoderProviderConfigurationUtils and NimbusJwtDecoder.
It's fixing Issue GH-14269
Since the
RestOperationsinstance inJwkSetUriJwtDecoderBuilderis not static, I couldn't have used a static initializer block and had to use the following solution. I am open to suggestions if you think there is a better solution for this.