Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support expressions in MethodAuthorizationDeniedHandler #14912

Closed
wants to merge 1 commit into from
Closed

Support expressions in MethodAuthorizationDeniedHandler #14912

wants to merge 1 commit into from

Conversation

franticticktick
Copy link
Contributor

Closes gh-14857

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Apr 15, 2024
jzheaux
jzheaux requested changes Apr 15, 2024
View reviewed changes
Copy link
Contributor

@jzheaux jzheaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @CrazyParanoid! It looks like that ticket was just a little out of date. Could you please update your PR to match the syntax of the now-updated ticket?

@franticticktick
Copy link
Contributor Author

Hi @jzheaux ! Thanks for your feedback. I have updated the PR as per your comments.

@franticticktick franticticktick requested a review from jzheaux April 15, 2024 18:09
@jzheaux jzheaux requested a review from marcusdacoregio April 16, 2024 00:23
@jzheaux jzheaux added in: core An issue in spring-security-core type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Apr 16, 2024
@jzheaux jzheaux changed the title Add support expressions in MethodAuthorizationDeniedHandler Support expressions in MethodAuthorizationDeniedHandler Apr 17, 2024
@marcusdacoregio
Copy link
Contributor

Thanks for the PR @CrazyParanoid. Since 6.3 is right around the corner, this feature will probably be reviewed and merged when the 6.4 branch is created. I appreciate your patience.

@marcusdacoregio
Copy link
Contributor

Hi, @CrazyParanoid. Thanks for the PR, I appreciate your efforts here.

I'll close this for now for the reasons mentioned in #14857 (comment). Please, leave any feedback in the issue comments and let's wait for the community feedback before moving further with such feature.

@marcusdacoregio marcusdacoregio added the status: declined A suggestion or change that we don't feel we should currently apply label Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jzheaux jzheaux Awaiting requested review from jzheaux

@marcusdacoregio marcusdacoregio Awaiting requested review from marcusdacoregio

Assignees

@marcusdacoregio marcusdacoregio

Labels
in: core An issue in spring-security-core status: declined A suggestion or change that we don't feel we should currently apply type: enhancement A general enhancement
Projects
Spring Security Team
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Expressions in Method Authorization Denied Handlers
4 participants
@franticticktick @marcusdacoregio @jzheaux @spring-projects-issues