Improved error message for PasswordEncoder #14968
Conversation
spring-projects-issues
added
the
status: waiting-for-triage
|
Hi, @bottlerocketjonny! Yes, we already received another PR for the same and I think it is a nice improvement. That said, if you'd like, please rebase once that is merged and push any other changes you'd like to see to this PR, and we can take a look together. |
No worries! Yeah sure thing I shall do that 👍🏻 Just for future reference, if I wanted to work on an issue should I wait to be assigned or just go for it? I left a comment on this one but wasn't sure if that was the way to go. Cheers 😀 |
|
@bottlerocketjonny, it's certainly better when I'm on top of folks' comments in tickets so that there isn't confusion. :) Sorry that you and the other contributor ended up working on the same feature. It's rare for two people to contribute near the same time, so we don't have a stated policy. Mostly, it's a best effort on my part to notice the comment, assign the issue to that person, and in the absence of that, attend to the first submitted PR. In your case, I'm happy that there were good ideas in both PRs, so I'd still encourage you to rebase. |
bottlerocketjonny
force-pushed
the
improved-error-message-password-encoder
branch
from
e161962 to
7e29776
Compare
There was a problem hiding this comment.
Thanks for the updates, @bottlerocketjonny! I've left some feedback inline.
Also, will you please update your commit message to include the ticket #14880 like so:
Your Title
Issue gh-14880
That will link this work to that ticket in GitHub, making it easier to track in the future.
...to/src/main/java/org/springframework/security/crypto/password/DelegatingPasswordEncoder.java
Outdated
Show resolved
Hide resolved
...to/src/main/java/org/springframework/security/crypto/password/DelegatingPasswordEncoder.java
Outdated
Show resolved
Hide resolved
...src/test/java/org/springframework/security/provisioning/InMemoryUserDetailsManagerTests.java
Show resolved
Hide resolved
...to/src/main/java/org/springframework/security/crypto/password/DelegatingPasswordEncoder.java
Outdated
Show resolved
Hide resolved
...c/test/java/org/springframework/security/crypto/password/DelegatingPasswordEncoderTests.java
Show resolved
Hide resolved
jzheaux
added
in: crypto
|
@jzheaux Oh gosh, so sorry I completely missed that you'd replied here. I'll get this sorted ASAP so we can close this issue. |
|
@jzheaux I've just pushed some new commits that I think are an improvement - let me know if anything else needs changing and apologies again for my tardiness! :) |
Closes spring-projectsgh-14880 Signed-off-by: Jonny Coddington <[email protected]>
jzheaux
force-pushed
the
improved-error-message-password-encoder
branch
from
76af19a to
0dca793
Compare
|
Thanks, @bottlerocketjonny! This is now merged into |
Excellent! Thanks for your patience. |
I fear I might have been too slow to submit this! However, this closes gh-14880
Happy to make any changes.