Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor Documentation update on import needed for using Kotlin DSL #14969

Conversation

madorb
Copy link
Contributor

@madorb madorb commented Apr 26, 2024

Updates the documentation to provide a bit more explicit instruction on how to enable the Kotlin DSL. I found the existing reference to

import the invoke function

a bit less obvious then I would have thought, and despite being reasonably knowledgable, having done this thing before in the past, and having the code sample, it took me a few minutes to figure out exactly what it was referring to.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Apr 26, 2024
@madorb madorb force-pushed the madorb-update-kotlin-dsl-import-doc branch 5 times, most recently from c82ec7b to aa617cb Compare April 26, 2024 14:57
@jzheaux jzheaux self-assigned this Apr 26, 2024
@jzheaux jzheaux added in: docs An issue in Documentation or samples type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Apr 26, 2024
@jzheaux jzheaux added this to the 6.3.0 milestone Apr 26, 2024
@jzheaux
Copy link
Contributor

jzheaux commented Apr 26, 2024

Thanks, @madorb! WIll you please do me the favor of formatting your commit like so?

An example might be something like:

Clarify Package Import

Provide more explict instructions regarding the necessary import 
to make the Kotlin DSL work. For some reason it took me 10 minutes 
to figure this out based on the existing doc.

@madorb madorb force-pushed the madorb-update-kotlin-dsl-import-doc branch from aa617cb to ef89fa8 Compare April 27, 2024 00:33
@madorb
Copy link
Contributor Author

madorb commented Apr 27, 2024

@jzheaux done!

Provide more explict instructions regarding the necessary import
to make the Kotlin DSL work. For some reason it took me 10 minutes
to figure this out based on the existing doc.
@madorb madorb force-pushed the madorb-update-kotlin-dsl-import-doc branch from ef89fa8 to 22ca3cc Compare April 27, 2024 00:36
@marcusdacoregio marcusdacoregio merged commit 1ae99be into spring-projects:main Apr 30, 2024
2 checks passed
@marcusdacoregio
Copy link
Contributor

Thanks, @madorb. This is now merged into main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: docs An issue in Documentation or samples type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants