Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The SecuredAuthorizationManager can now find @Secured annotations on … #15014

Closed
wants to merge 1 commit into from

Conversation

abimael-turing
Copy link

…subclasses when a method in the superclass is called.

closes the issue #15002

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label May 6, 2024
@abimael-turing
Copy link
Author

@artem103 and @spring-projects-issues, I completed the pull request, but the build is failing on GitHub due to deprecated Gradle features, which are incompatible with Gradle 8.0.

Uploading image.png…

@abimael-turing
Copy link
Author

@artem103 and @spring-projects-issues, I completed the pull request, but the build is failing on GitHub due to deprecated Gradle features, which are incompatible with Gradle 8.0.

image

@rishiraj88
Copy link
Contributor

@artem103 and @spring-projects-issues, I completed the pull request, but the build is failing on GitHub due to deprecated Gradle features, which are incompatible with Gradle 8.0.

image

@abimael-turing , how did you start this build- with 'gradlew' or 'gradle' executable directly? gradlew is well known to handle cross-version compatibility issues.

@abimael-turing
Copy link
Author

abimael-turing commented May 7, 2024

@artem103 and @spring-projects-issues, I completed the pull request, but the build is failing on GitHub due to deprecated Gradle features, which are incompatible with Gradle 8.0.
image

@abimael-turing , how did you start this build- with 'gradlew' or 'gradle' executable directly? gradlew is well known to handle cross-version compatibility issues.

Hello @rishiraj88, just to clarify, I didn't initiate the build process myself. Instead, I opened a pull request on GitHub and requested a merge, which then triggered the build process. The error that occurred seems to be happening within Gradle on GitHub's end, rather than on my local computer. From what I can tell, it appears that GitHub is attempting to compile the code using outdated Gradle configurations, while simultaneously running a newer version of Gradle, which is causing compatibility issues to arise.

image

@jzheaux
Copy link
Contributor

jzheaux commented May 21, 2024

@abimael-turing, I'm not yet certain if we will be able to backport this to a maintenance version, however I've updated the branch so that it builds.

To more fully backport this behavior, will you please consider changing the PR to cherry-pick b0da37d instead? In this way, all the annotations will get the same benefit.

In the meantime, I'd like to see how the feature is received in 6.3 before merging.

@jzheaux jzheaux self-assigned this May 21, 2024
@jzheaux jzheaux added in: core An issue in spring-security-core type: enhancement A general enhancement status: blocked An issue that's blocked on an external project change and removed status: waiting-for-triage An issue we've not yet triaged labels May 21, 2024
@jzheaux jzheaux added this to the 5.8.13 milestone May 21, 2024
@sjohnr sjohnr modified the milestones: 5.8.13, 5.8.14 Jun 17, 2024
@sjohnr sjohnr modified the milestones: 5.8.14, 5.8.15 Aug 19, 2024
@jzheaux
Copy link
Contributor

jzheaux commented Sep 4, 2024

After some additional research, @abimael-turing, this feature was reverted in f20ae1a for 6.3.x and onward.

As such, I'm going to close this issue. In general, annotations declared lower in the hierarchy do not affect methods higher in the hierarchy.

@jzheaux jzheaux closed this Sep 4, 2024
@jzheaux jzheaux added status: declined A suggestion or change that we don't feel we should currently apply in: data An issue in spring-security-data and removed status: blocked An issue that's blocked on an external project change labels Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core An issue in spring-security-core in: data An issue in spring-security-data status: declined A suggestion or change that we don't feel we should currently apply type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants