Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always Use Request-Level ServletContext to Evaluate Request Matcher Paths #15195

Merged
merged 2 commits into from
Jun 3, 2024

Conversation

jzheaux
Copy link
Contributor

@jzheaux jzheaux commented Jun 3, 2024

Closes gh-14418

jzheaux added 2 commits June 3, 2024 16:23
Spring Security cannot use the ServletContext attached
to the ApplicationContext since there may be child
ApplicationContext's with their own ServletContext.

Because of that, it is necessary to always use the
ServletContext attached to the request.

Closes spring-projectsgh-14418
@jzheaux jzheaux added in: config An issue in spring-security-config type: bug A general bug labels Jun 3, 2024
@jzheaux jzheaux added this to the 5.8.13 milestone Jun 3, 2024
@jzheaux jzheaux self-assigned this Jun 3, 2024
@jzheaux jzheaux changed the base branch from main to 5.8.x June 3, 2024 23:40
@jzheaux jzheaux merged commit cdd6266 into spring-projects:5.8.x Jun 3, 2024
4 checks passed
@jzheaux jzheaux deleted the gh-14418 branch June 3, 2024 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: config An issue in spring-security-config type: bug A general bug
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

DispatcherServletDelegatingRequestMatcher causes errors when there is more than one ServletContext
1 participant