Allow logout+jwt JWT type for reactive #15847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
|
Thanks, @c1rd3cm! Before this gets merged, will you please update the commit message so that it ends with the following on its own line: This will allow the associated issue to be closed upon merge. It also makes it easier to perform research in the future when ascertaining why a certain change was made. |
jzheaux
added
type: enhancement
The OIDC back-channel spec recommends using a logout token typ `logout+jwt` (see [here](https://openid.net/specs/openid-connect-backchannel-1_0-final.html#LogoutToken). Support of this type was recently added [on the servlet side]([on the Servlet side](spring-projects@9101bf1)), so back porting the same on the reactive side to close the gap. Closes spring-projectsgh-15702
|
Thanks for the review @jzheaux. Sorry, this is my first time submitting a PR, and I saw that I missed the reference to the issue in my commit but I thought that having it the PR would be enough. I updated my commit description and did a force push, I hope this is the right way. |
spring-projects-issues
added
status: feedback-provided
|
Looks great, @c1rd3cm. Thanks for the update. |
|
Thanks again, @c1rd3cm! This is now merged into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The OIDC back-channel spec recommends using a logout token typ
logout+jwt(see here).Support of this type was recently added on the Servlet side, so backporting the same on the reactive side to
close the gap.
Closes gh-15702