Catch base64 decode exception #15914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
kse-music
force-pushed
the
gh-15905
branch
2 times, most recently
from
f72ea53 to
e1f224c
Compare
jzheaux
requested changes
Oct 14, 2024
There was a problem hiding this comment.
Thanks, @kse-music! I've left some feedback inline. Also, please update the copyright years to any non-Acegi copyright messages.
web/src/main/java/org/springframework/security/web/savedrequest/CookieRequestCache.java
Show resolved
Hide resolved
jzheaux
added
in: web
|
Thanks for the updates, @kse-music! Can you please update the copyright for the test file as well? |
|
@jzheaux I have been updated |
jzheaux
approved these changes
Oct 24, 2024
|
Thanks, @kse-music! This is now merged into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes gh-15905
This is also aligned with
CookieServerRequestCache