Add DefaultResourcesFilter.webauthn() #15970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
sjohnr
added
in: web
rwinch
requested changes
Nov 8, 2024
.../java/org/springframework/security/config/annotation/web/configurers/WebAuthnConfigurer.java
Outdated
Show resolved
Hide resolved
Kehrlann
force-pushed
the
webauthn-default-resource-filter
branch
from
9d708be to
05955a9
Compare
Kehrlann
changed the title
- Unconditionally use the DefaultResourcesFilter, because the javascript file is required by the DefaultWebAythnPageGeneratingFilter, which is always registered.
Kehrlann
force-pushed
the
webauthn-default-resource-filter
branch
from
05955a9 to
708e052
Compare
rwinch
requested changes
Nov 14, 2024
.../java/org/springframework/security/config/annotation/web/configurers/WebAuthnConfigurer.java
Show resolved
Hide resolved
Kehrlann
force-pushed
the
webauthn-default-resource-filter
branch
from
708e052 to
b276958
Compare
rwinch
changed the title
rwinch
approved these changes
Nov 14, 2024
|
Thanks for the Pull Request! This is now merged into main 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reviewer: @rwinch
Description
Use
DefaultResourcesFilterwith a proper static method for webauthn pages.The filter is registered when:
This means the filter may end up registered twice, which may cause a slight performance hit. We accept this tradeoff for code simplicity, since this is not intended for production workloads anyways.