switches web authentication principal resolver to use reactive context (#6598) #7687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
gh #6598 Signed-off-by: David Herberth <[email protected]>
eleftherias
added
in: web
|
Thanks for the PR @Dav1dde! This is now merged into master. |
robotmrv
reviewed
Dec 22, 2019
| .ofType(Authentication.class) | ||
| .flatMap( a -> { | ||
| return ReactiveSecurityContextHolder.getContext() | ||
| .map(SecurityContext::getAuthentication) |
There was a problem hiding this comment.
@Dav1dde @eleftherias
By javadoc SecurityContext::getAuthentication could return null
Mono.map forbids null
should this case be handled, or it is very unlikely to happen
There was a problem hiding this comment.
Looking at the implementation of ReactiveSecurityContextHolder this may very well be the case (the API allows it).
This would also need to be fixed in multiple other AuthenticationPrinicipalArgumentResolver implementations, e.g. in messaging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation for #6598 as noted by @eleftherias
Replacing
exchange.getPrincipal()withReactiveSecurityContextHolder.getContext().map(SecurityContext::getAuthentication)inAuthenticationPrincipalArgumentResolver.Other implementations of
AuthenticationPrincipalArgumentResolverare already doing that (messaging).One thing I noticed was, the logic for
AuthenticationPrincipalArgumentResolverexists multiple times (like 2-3 duplicates), maybe it's time to refactor the logic out into an abstract base class.