Ensure compatibility with previous version of spring data #2627
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, thank you very much for accepting my previous contribution :D
This is a follow up to #2626
I saw that you did some changes to it, in particular moving the bean declaration from a dedicated configuration class to the already present
SpringDocPageableConfiguration
.This sadly breaks compatibility with spring data < 3.3.0 because without the
@ConditionalOnClass(PagedModel.class)
as a safeguard the@ConditionalOnBean
alone isn't safe to use and aClassNotFoundException
is thrown when the class isn't on the classpath.I tweaked a bit the bean declaration to make sure that it doesn't break anymore if
SpringDataWebSettings
isn't present.