-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sudo
support for npm installer.
#216
base: master
Are you sure you want to change the base?
Conversation
`fgrep` is faster than `grep`.
What is fgrep? This has to work on a ton of diff platforms. OS X, other BSDs, Linux and its proliferation of distros. Unless there is a big reason to change grep is probably safer, no? |
Same as
Since Anywhere, |
`fgrep` is deprecated according to `man grep`.
end | ||
end | ||
|
||
verify_api do | ||
def has_npm(package) | ||
@commands << "npm --global list | grep \"#{package}@\"" | ||
@commands << "npm --global list | grep -F \"#{package}@\"" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think to be correct her we need to match " [package]" (space in front), based on the output - to avoid false matches, yes? I'd say fix this and we can merge.
No description provided.