Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter out passwords, as much as possible. #5

Closed
jfinkhaeuser opened this issue Jul 2, 2015 · 2 comments
Closed

Filter out passwords, as much as possible. #5

jfinkhaeuser opened this issue Jul 2, 2015 · 2 comments
Assignees
@jfinkhaeuser
Labels
enhancement

Comments

@jfinkhaeuser
Copy link
Contributor

From spriteCloud/regressinator-worker#12
@jfinkhaeuser jfinkhaeuser self-assigned this Jul 2, 2015
@jfinkhaeuser
Copy link
Contributor Author

Filtering out passwords from arrays and objects that get logged is a distinct possibility, and we should do that for security reasons.

Filtering out passwords from strings would require some kind of parsing of the string... I suspect that's beyond the scope of teelogger.

jfinkhaeuser added a commit that referenced this issue Jul 6, 2015
@jfinkhaeuser
In preparation for #5, refactor the dispatch code a little
61597fa
jfinkhaeuser added a commit that referenced this issue Jul 6, 2015
@jfinkhaeuser
Start of tests for #5
ee0d837
jfinkhaeuser added a commit that referenced this issue Jul 6, 2015
@jfinkhaeuser
For #5, add basic filter framework.
01fe904
jfinkhaeuser added a commit that referenced this issue Jul 6, 2015
@jfinkhaeuser
For #5, use filter framework from previous commit
668642e
jfinkhaeuser added a commit that referenced this issue Jul 6, 2015
@jfinkhaeuser
Implementation of #5 uses require_all
675a088
jfinkhaeuser added a commit that referenced this issue Jul 6, 2015
@jfinkhaeuser
Relating to #5, get rid of some debug output
91354ce
jfinkhaeuser added a commit that referenced this issue Jul 6, 2015
@jfinkhaeuser
Add test scenarios for #5
acbed8f
jfinkhaeuser added a commit that referenced this issue Jul 6, 2015
@jfinkhaeuser
For #5, don't rely on in-place argument manipulation
0f5445e
jfinkhaeuser added a commit that referenced this issue Jul 6, 2015
@jfinkhaeuser
Add a test case for #5 using a custom filter
de11ee6
jfinkhaeuser added a commit that referenced this issue Jul 6, 2015
@jfinkhaeuser
For #5, add a test scenario that filters CLI-style arrays
7dd82d1
jfinkhaeuser added a commit that referenced this issue Jul 6, 2015
@jfinkhaeuser
Simple CLI filter implementation for #5; currently fails due to the rest
f9a91aa 
of the filtering code
jfinkhaeuser added a commit that referenced this issue Jul 6, 2015
@jfinkhaeuser
For #5, make CLI filter exit gracefully if the window size is wrong
aba64e7
jfinkhaeuser added a commit that referenced this issue Jul 6, 2015
@jfinkhaeuser
For #5, iterate over windows such that in-place replacement is possible
8205139
jfinkhaeuser added a commit that referenced this issue Jul 6, 2015
@jfinkhaeuser
For #5, make filter registration part of the logger instance, not the…
dadfaf9 
… module
jfinkhaeuser added a commit that referenced this issue Jul 6, 2015
@jfinkhaeuser
For #5, fix the tests
45468a5 
- custom filter will nil everything, truncating is not permitted
- register filters/filter words with logger instance
jfinkhaeuser added a commit that referenced this issue Jul 6, 2015
@jfinkhaeuser
For #5, sanity check filter results: the results tuple must have the
aedbc3a 
same size as the original tuple
@jfinkhaeuser
Copy link
Contributor Author

Looks like that's it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jfinkhaeuser jfinkhaeuser

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jfinkhaeuser