Support new ssh keys formats: rsa, ecdsa, and ed25519 #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxcnunes
force-pushed
the
fix-ssh-connection-new-openssh
branch
from
71e61e4 to
5c6cb9a
Compare
maxcnunes
force-pushed
the
fix-ssh-connection-new-openssh
branch
3 times, most recently
from
5cbad75 to
62c0581
Compare
maxcnunes
changed the title
maxcnunes
force-pushed
the
fix-ssh-connection-new-openssh
branch
24 times, most recently
from
cf55e47 to
fafc7b0
Compare
maxcnunes
force-pushed
the
fix-ssh-connection-new-openssh
branch
2 times, most recently
from
9ae25fc to
bad0a2a
Compare
maxcnunes
force-pushed
the
fix-ssh-connection-new-openssh
branch
from
bad0a2a to
c624a51
Compare
maxcnunes
commented
Mar 24, 2021
maxcnunes
commented
Mar 24, 2021
maxcnunes
commented
Mar 24, 2021
Closed
MasterOdin
approved these changes
Mar 26, 2021
Comment on lines
51
to
+53
| - 9042 # native | ||
| ports: | ||
| - 9042:9042 |
There was a problem hiding this comment.
Suggested change
| - 9042 # native | |
| ports: | |
| - 9042:9042 | |
| - 9042:9042 # native |
|
|
||
| test: | ||
| image: node:10.15.0 | ||
| image: node:10.24.0 |
There was a problem hiding this comment.
Suggested change
| image: node:10.24.0 | |
| image: node:12 |
might as well use a version of node that supports the new ssh key formats as well.
| const dbConn = serverSession.createConnection(database); | ||
|
|
||
| // ed25519 is only supported by node v12+ | ||
| if (keyType === 'ed25519' && (process.version.startsWith('v10') || process.version.startsWith('v8'))) { |
There was a problem hiding this comment.
Suggested change
| if (keyType === 'ed25519' && (process.version.startsWith('v10') || process.version.startsWith('v8'))) { | |
| if (keyType === 'ed25519' && process.version.startsWith('v10')) { |
Minimum supported version for this package is 10.13, so don't need to worry about the test suite running on 8.x:
sqlectron-db-core/package.json
Lines 35 to 37 in 0369c8a
|
@MasterOdin FYI, I won't apply any of the suggestions you made to this PR because I have already fixed them in the last PR, so I don't need to rebase it all over again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will fix sqlectron/sqlectron-gui#471
Upgrades to a new ssh2 version which has support for new ssh key formats: rsa, ecdsa, and ed25519 mscdex/ssh2#352 (comment)