Add ssh agent option #624
Merged
Add ssh agent option #624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxcnunes
force-pushed
the
ssh-fix
branch
4 times, most recently
from
f994e21 to
52cc98b
Compare
MasterOdin
approved these changes
Mar 30, 2021
| TMPDIR: /usr/src/app/.tmp | ||
| volumes: | ||
| - .:/usr/src/app | ||
| version: '3' |
There was a problem hiding this comment.
Are you still using this file for anything? Should it be removed?
There was a problem hiding this comment.
It was used for builds when we just had Ubuntu OS in the CI. But, it maybe makes sense keeping it around just in case we need to test a build locally for other OS than our own host OS.
|
The intention was adding the test for basic private key only because of the fixing for private keys which comes with the db-core upgrade. But it should be simple to add a test for ssh agent as well. I will do it later today after working hours. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will close #471
Working in progress, still need to add tests