Fix brigthness #133
Open
Fix brigthness #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The most accurate way to set brigthness for RGB, is to alway take the max R,G,B value (If you try a colorpicker, you set 150, 43,56, and you change only the hue, you alway have 150 on R, G or B, and brigthness will not change. exemaple : With RGB (0 ,0, 255) you expect a 100% brigth blue so bri = 255 If you take Y you have a wrong very low blue (4,7% brightness).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The most accurate way to set brigthness for RGB, is to alway take the max R,G,B value (If you try a colorpicker, you set 150, 43,56, and you change only the hue, you alway have 150 on R, G or B, and brigthness will not change.
exemaple : With RGB (0 ,0, 255) you expect a 100% brigth blue so bri = 255
If you take Y you have a wrong very low blue (4,7% brightness).