Fix CDC Message for DeleteLabel
#63
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CDC message generated by `DeleteLabel` doesn't include a value in the `new` field, and the `old` entity is the original entity before the label is removed. This prevents the CDC message from being useful as you cannot determine what changed about the entity.
|
seems reasonable to me but are there any relevant tests to update? |
- Updated unit tests for changes to CDC `DeleteLabel` - Adjusted mongo test setup as indexes were not being created
|
Yes. Updated. |
daniel-nichter
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CDC message generated by
DeleteLabeldoesn't include a value in thenewfield, and theoldentity is the original entity before the label is removed. This prevents the CDC message from being useful as you cannot determine what changed about the entity.