Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1076: Type names in a line comment may break the line #1174

Merged
merged 1 commit into from
Oct 20, 2021

Conversation

glureau
Copy link

@glureau glureau commented Oct 15, 2021

Avoid comments to be broken due to line wrapping applied on %T
These types are now out of line wrapping:

  • lambda suspend Foo(bar: Bar) -> Flux
  • parameterized type Map<out Foo, in Bar>

@glureau glureau force-pushed the long_type_names_in_comment branch from 4e03e4b to b1e64d0 Compare October 15, 2021 21:17
@glureau glureau force-pushed the long_type_names_in_comment branch from b1e64d0 to d34c32b Compare October 15, 2021 21:21
Copy link
Collaborator

@Egorand Egorand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@Egorand Egorand merged commit 06ad1f1 into square:master Oct 20, 2021
@glureau glureau deleted the long_type_names_in_comment branch October 20, 2021 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants