-
Notifications
You must be signed in to change notification settings - Fork 519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Format mgr:sbuf report as YAML #1795
base: master
Are you sure you want to change the base?
Conversation
Only formatting changes were performed. A couple of keys were simplified/clarified.
sample output with PR applied: SBuf stats:
allocations: 9886
copy-allocations: 4507
copy-allocations from cstring: 729
live references: 2058
no-copy assignments: 1248
clearing operations: 3194
append operations: 5361
move operations: 853
dump-to-ostream: 108
set-char: 1247
get-char: 2637
comparisons with data-scan: 642
comparisons not requiring data-scan: 8
copy-out ops: 9
raw access to memory: 8549
NULL terminate cstring: 1174
chop operations: 5047
trim operations: 0
find: 1281
case-change ops: 68
COW completely avoided: 723
COW replaced with memmove: 0
COW requiring an empty buffer allocation: 2064
COW requiring allocation and copying: 170
average store share factor: 1.549
MemBlob stats:
allocations: 2235
live instances: 1322
append calls: 4071
cumulative size bytes: 63296
mean size: 47.9
SBuf size distribution at destruct time:
30-30: 70
31-32: 1
33-33: 1
37-38: 2
38-39: 1
43-45: 5
59-63: 3
97-106: 1
MemBlob capacity distribution at destruct time:
31-32: 5
63-67: 1 |
StatHist has a definitely dated API, but this is not the PR to change that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please wait for spaces() issue to be resolved before posting more YAML PRs or requesting additional reviews.
(ststats.live != 0 ? static_cast<float>(live)/ststats.live : 0) << | ||
std::endl; | ||
return os; | ||
const std::string indent(" "); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do not use std::string in primary Squid code. In most cases (probably including this one), using SBuf is best. I am aware that this code reports SBuf stats.
No description provided.