Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PSR12.Functions.NullableTypeDeclaration false positive when ternary operator used with instanceof #2791

Closed
asika32764 opened this issue Jan 1, 2020 · 2 comments · Fixed by #2794
Closed

PSR12.Functions.NullableTypeDeclaration false positive when ternary operator used with instanceof #2791

asika32764 opened this issue Jan 1, 2020 · 2 comments · Fixed by #2794
Labels
Type: bug
Milestone
3.5.4

Comments

@asika32764
Copy link

This code will return There must not be a space between the question mark and the type in nullable type declarations

return $value instanceof static ? '(' . $value . ')' : $value;

8E7EEA1A-7EEF-45E7-8612-51C7869F6D9E

Snuffer version: 3.5.3
@jrfnl
Copy link
Contributor

jrfnl commented Jan 1, 2020

@asika32764 Tested & confirmed as a tokenizer bug.

@jrfnl jrfnl mentioned this issue Jan 2, 2020
Merged
@gsherwood gsherwood changed the title [PSR-12] Ternary operator with instanceof is wrong PSR12.Functions.NullableTypeDeclaration false positive when ternary operator used with instanceof Jan 5, 2020
@gsherwood gsherwood added this to the 3.5.4 milestone Jan 5, 2020
gsherwood added a commit that referenced this issue Jan 5, 2020
@gsherwood
Changelog for #2791 (ref #2794)
48302f1
@gsherwood
Copy link
Member

Thanks for reporting this. Fix will be in 3.5.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: bug
Projects
None yet
Milestone
3.5.4
Development

Successfully merging a pull request may close this issue.

Tokenizer: improve tokenization of T_NULLABLE vs T_INLINE_THEN jrfnl/PHP_CodeSniffer
3 participants
@gsherwood @jrfnl @asika32764