PHP 8.0 | Tokenizer/PHP: support PHP8 magic constant dereferencing #3013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of PHP 8, magic constants can be dereferenced, however, the square brackets are incorrectly tokenized as _short array_ brackets instead of as "normal" square brackets. Fixed by: * Adding a new `$magicConstants` array to the `Util\Tokens` calls. * Adding the `$magicConstants` to the allowed tokens for leaving the brackets alone in the PHP Tokenizer class. Includes adding unit tests for this section of the `PHP::processAdditional()` method. I've added as many relevant syntaxes as I could come up with, but won't claim that the unit test case file covers every possible scenario. Should be a good start though. Ref: https://wiki.php.net/rfc/variable_syntax_tweaks#constants_and_magic_constants
This was referenced Jul 10, 2020
|
Test build which includes PR #3014 which confirms that the build for this PR would pass on PHP 8/nightly: https://travis-ci.com/github/jrfnl/PHP_CodeSniffer/jobs/360290642 |
|
Thanks |
|
@gsherwood Should the new token array get a mention in the changelog ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of PHP 8, magic constants can be dereferenced, however, the square brackets are incorrectly tokenized as short array brackets instead of as "normal" square brackets.
Fixed by:
$magicConstantsarray to theUtil\Tokenscalls.$magicConstantsto the allowed tokens for leaving the brackets alone in theTokenizers\PHPclass.Includes adding unit tests for this section of the
PHP::processAdditional()method.I've added as many relevant syntaxes as I could come up with, but won't claim that the unit test case file covers every possible scenario. Should be a good start though.
Ref: https://wiki.php.net/rfc/variable_syntax_tweaks#constants_and_magic_constants