Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd: warns if none organization is provided exiting without error #65

Merged
merged 1 commit into from
Jul 18, 2019
Merged

cmd: warns if none organization is provided exiting without error #65

merged 1 commit into from
Jul 18, 2019

Conversation

mcarmonaa
Copy link
Contributor

Closes #64

@mcarmonaa mcarmonaa requested a review from jfontan July 18, 2019 09:40
dpordomingo
dpordomingo approved these changes Jul 18, 2019
View reviewed changes
Copy link
Contributor

@dpordomingo dpordomingo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dpordomingo
Copy link
Contributor

LGTM because it's consistent with how we use gitcollector in sourced init local
But we could wait for confirmation from the rest of @src-d/applications team

@dpordomingo dpordomingo mentioned this pull request Jul 18, 2019
Merged
@mcarmonaa mcarmonaa merged commit 66b7544 into src-d:master Jul 18, 2019
@mcarmonaa mcarmonaa deleted the fix/cmd-warn-no-organizations branch July 18, 2019 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfontan jfontan jfontan approved these changes

@dpordomingo dpordomingo dpordomingo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gitcollector should not start when no org is passed
3 participants
@mcarmonaa @dpordomingo @jfontan