Env variables #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes Unknown when pulling 2cbbfdb on Maxim-Filimonov:env_variables into ** on sretundijr:master**. |
|
Careful with this solution. It bakes in the env vars at build time, not run-time. Apps may be built on different machines than the one they launch on. A common example is a Heroku pipeline. I've seen apps built for staging, then "promoted" to production with staging variables baked into the app. |
|
@JonAbrams what are you proposals for static application hosted on Netlify ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently Babel doesn't do what we wanted found the solution web Webpack define plugin instead.
This works tested on local machine