Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using github:nix-systems #83

Closed
srid opened this issue Jul 12, 2024 · 2 comments
Closed

Stop using github:nix-systems #83

srid opened this issue Jul 12, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@srid
Copy link
Owner

srid commented Jul 12, 2024

let url = if known_nix_systems.contains(&s) {
format!("github:nix-systems/{}", s)
} else {

Rationale

We keep hitting GitHub rate limits despite passing a token at the nixci CLI level:

https://github.com/juspay/omnix/actions/runs/9910699850/job/27381695570

image

Solution

We could embed all the system lists of https://github.com/nix-systems locally in nixci, and refer to it using local path, which should not require network access.

@srid srid added the enhancement New feature or request label Jul 12, 2024
@srid
Copy link
Owner Author

srid commented Jul 12, 2024

srid added a commit to juspay/omnix that referenced this issue Jul 12, 2024
Also fix CI to not use nix-systems

srid/nixci#83
@srid srid pinned this issue Jul 12, 2024
srid added a commit that referenced this issue Jul 12, 2024
@srid
Copy link
Owner Author

srid commented Aug 7, 2024

juspay/omnix#210

@srid srid closed this as not planned Won't fix, can't repro, duplicate, stale Aug 7, 2024
@srid srid unpinned this issue Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant