refactor: optimize subnet calculations using big.Int for reduced memory usage #1969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Roy-blox
approved these changes
Dec 29, 2024
moshe-blox
reviewed
Dec 29, 2024
network/commons/common.go
Outdated
Comment on lines
71
to
75
| // SetCommitteeSubnet returns the subnet for the given committee, it doesn't allocate memory but uses the passed in big.Int | ||
| func SetCommitteeSubnet(bigInst *big.Int, cid spectypes.CommitteeID) uint64 { | ||
| bigInst.SetBytes(cid[:]) | ||
| return bigInst.Mod(bigInst, bigIntSubnetsCount).Uint64() | ||
| } |
There was a problem hiding this comment.
i think it would make more sense if it just set the value and not returned it
the caller can just call Uint64() and it would emphasize the big.Int is being modified (even without reading comment)
that's less convenient, but it's an optimized alternative func so it's OK imo
moshe-blox
reviewed
Dec 29, 2024
operator/validator/controller.go
Outdated
| func (c *controller) selfSubnets() records.Subnets { | ||
| // selfSubnets calculates the operator's subnets by adding up the fixed subnets and the active committees | ||
| // it recvs big int to avoid unnecessary conversions, if intCid is nil it will allocate a new big int | ||
| func (c *controller) selfSubnets(intCid *big.Int) records.Subnets { |
There was a problem hiding this comment.
externally the big.Int is just a buffer and has no usage outside this func, so to avoid confusion i'd call it just "buffer" and clarify it's for re-using memory (we can keep explanation about cid but don't have to IMO)
There was a problem hiding this comment.
taking inspiration from https://pkg.go.dev/bytes#Buffer
which has a similar pattern to what you did where if you dont pass buf it will allocate for you
Codecov ReportAttention: Patch coverage is
Additional details and impacted files☔ View full report in Codecov by Sentry. |
nkryuchkov
added a commit
that referenced
this pull request
Jan 12, 2025
moshe-blox
added a commit
that referenced
this pull request
Jan 15, 2025
…adata sync (#1805) * rename setupEventHandling to syncContractEvents * refactor beaconprotocol.UpdateValidatorsMetadata to MetadataFetcher * don't pass logger to operatorNode.Start() * don't pass logger to reportOperators * don't pass logger to p2pNetwork Setup and Start * fix TestSetupValidatorsExporter * reduce errors text in fetchAndUpdateValidatorsMetadata * extract a package for metadata updating; start it before p2p setup * minor cleanup * pass context * get rid of update metadata loop in validator controller * remove unused code from validator controller * fix tests for StartValidators * initialize metadata updater before validator controller * various fixes in metadata updater * sharesStorage -> shareStorage * remove redundant comment * avoid blocking on channel send * return shares instead of nil on timeout * fix TODO's; add tests * fix linter * review comments and some code improvements * review comments [2] * minor improvements * move metadata updater inside validator * review comments [3] * add comments * add another comment * network/p2p: extract logger changes to another PR * network/p2p: revert leftovers * resolve a busy loop * remove logic with indices diff * wrap context in reportIndicesChange * review comments * ValidatorSyncer -> Syncer * fix comment * rename receiver * get rid of fetcher * fix TestUpdateValidatorMetadata * NewValidatorSyncer -> NewSyncer * minor renames * add a comment in HandleMetadataUpdates * revert removal of active index comparison * add self subnets logic missed on merge conflicts * fix leftovers * apply changes from #1969 * filter shares by own subnets * use fixed subnets * improve the last batch sleep comment * minor rename * comments * comment * comment * logs --------- Co-authored-by: zippoxer <[email protected]>
oleg-ssvlabs
pushed a commit
that referenced
this pull request
Jan 20, 2025
…adata sync (#1805) * rename setupEventHandling to syncContractEvents * refactor beaconprotocol.UpdateValidatorsMetadata to MetadataFetcher * don't pass logger to operatorNode.Start() * don't pass logger to reportOperators * don't pass logger to p2pNetwork Setup and Start * fix TestSetupValidatorsExporter * reduce errors text in fetchAndUpdateValidatorsMetadata * extract a package for metadata updating; start it before p2p setup * minor cleanup * pass context * get rid of update metadata loop in validator controller * remove unused code from validator controller * fix tests for StartValidators * initialize metadata updater before validator controller * various fixes in metadata updater * sharesStorage -> shareStorage * remove redundant comment * avoid blocking on channel send * return shares instead of nil on timeout * fix TODO's; add tests * fix linter * review comments and some code improvements * review comments [2] * minor improvements * move metadata updater inside validator * review comments [3] * add comments * add another comment * network/p2p: extract logger changes to another PR * network/p2p: revert leftovers * resolve a busy loop * remove logic with indices diff * wrap context in reportIndicesChange * review comments * ValidatorSyncer -> Syncer * fix comment * rename receiver * get rid of fetcher * fix TestUpdateValidatorMetadata * NewValidatorSyncer -> NewSyncer * minor renames * add a comment in HandleMetadataUpdates * revert removal of active index comparison * add self subnets logic missed on merge conflicts * fix leftovers * apply changes from #1969 * filter shares by own subnets * use fixed subnets * improve the last batch sleep comment * minor rename * comments * comment * comment * logs --------- Co-authored-by: zippoxer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I observed high memory usage and a lot of allocations stemming from the
CommitteeSubnetcode used to calculate the subnets for which validators we should pull metadata for (Changed in #1787)Changes
SubnetsCountbig.Intrepresentation to reduce allocations.SetCommitteeSubnetwhich receives abig.Intinstance and uses it instead of allocating new ints.