Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support less strict versioning schemes #21

Merged
merged 6 commits into from
Dec 19, 2023
Merged

Support less strict versioning schemes #21

merged 6 commits into from
Dec 19, 2023

Conversation

staabm
Copy link
Owner

@staabm staabm commented Dec 19, 2023

before this PR we would get a exception for git tags with version 1.10 and similar (without a 3rd number)

  Internal error: Internal error: Version string '1.10' is not valid and cannot be parsed while analysing file                                                                 
     /Users/staabm/workspace/redaxo/redaxo/src/addons/diff_detect/lib/RssDiff.php                                                                                                 
                                                                                                                                                                                  
     Post the following stack trace to https://github.com/phpstan/phpstan/issues/new?template=Bug_report.yaml:                                                                    
     ## /Users/staabm/workspace/redaxo/redaxo/src/addons/rexstan/vendor/nikolaposa/version/src/Exception/InvalidVersionString.php(16)                                             
     #0 /Users/staabm/workspace/redaxo/redaxo/src/addons/rexstan/vendor/nikolaposa/version/src/Version.php(65): Version\Exception\InvalidVersionString::notParsable('1.10')       
     #1 /Users/staabm/workspace/redaxo/redaxo/src/addons/rexstan/vendor/staabm/phpstan-todo-by/src/ReferenceVersionFinder.php(22): Version\Version::fromString('1.10')       

@staabm staabm changed the title Improve less strict versioning schemes Support less strict versioning schemes Dec 19, 2023
@staabm staabm merged commit 909d958 into main Dec 19, 2023
11 checks passed
@staabm staabm deleted the ref branch December 19, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant