Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show readable error when ticket doesn't exist #61

Merged
merged 2 commits into from
Jan 4, 2024

Conversation

EmilMassey
Copy link
Contributor

Currently, if the ticket doesn't exist, exception is thrown. This PR fixes this and now it's reported as normal error: Ticket APP-000 doesn't exist.

Please note that 404 is also returned by Jira if provided credentials do not allow for viewing the ticket even if it exists so it's not possible to distinguish these two reasons.

@staabm
Copy link
Owner

staabm commented Jan 3, 2024

thanks for the PR.

Please note that 404 is also returned by Jira if provided credentials do not allow for viewing the ticket even if it exists so it's not possible to distinguish these two reasons.

we should reflect that in the error message.

@staabm staabm merged commit 8fe7476 into staabm:main Jan 4, 2024
11 of 12 checks passed
@staabm
Copy link
Owner

staabm commented Jan 4, 2024

thank you

@EmilMassey EmilMassey deleted the jira-404 branch January 4, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants