Use parallel http requests #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@EmilMassey could you double check whether this PR breaks something for you? |
staabm
commented
Jan 19, 2024
| $responseCode = curl_getinfo($handle, CURLINFO_RESPONSE_CODE); | ||
| $result[$url] = [$responseCode, $response]; | ||
|
|
||
| curl_multi_remove_handle($mh, $handle); |
There was a problem hiding this comment.
the curl PHP 7.4 phpstan errors are fixed with phpstan/phpstan-src#2882 in the next PHPStan release
staabm
commented
Jan 19, 2024
| /** | ||
| * @var array<string, ?string> | ||
| */ | ||
| private array $cache; |
There was a problem hiding this comment.
we no longer need the caching, because the fetcher now gets a full list of all ticket-keys without duplicates
|
@staabm Everything works as expected |
EmilMassey
approved these changes
Jan 20, 2024
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #76
requires the next phpstan release: phpstan/phpstan-src#2882 in the next PHPStan release