Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug when same GitHub issue is referenced in multiple ways #97

Merged
merged 1 commit into from
May 24, 2024

Conversation

EmilMassey
Copy link
Contributor

Currently in case of GitHub there are multiple ways we can use to reference the same issue. This PR fixes runtime exception (Missing ticket-status for key #59) that was thrown in this situation.

@staabm staabm merged commit 27166f4 into staabm:main May 24, 2024
16 checks passed
@staabm
Copy link
Owner

staabm commented May 24, 2024

Thanks

@staabm
Copy link
Owner

staabm commented May 24, 2024

the new test failed on the main branch after merge: https://github.com/staabm/phpstan-todo-by/actions/runs/9227566752/job/25389786214

@EmilMassey EmilMassey deleted the gh-bug branch May 24, 2024 17:23
@EmilMassey
Copy link
Contributor Author

EmilMassey commented May 24, 2024

the new test failed on the main branch after merge: https://github.com/staabm/phpstan-todo-by/actions/runs/9227566752/job/25389786214

The composer require step of failed pipeline used outdated git commit for some reason. Should have downloaded 27166f4 but fetched 774f707 instead. This is the previous version, that did not have the fix. See https://github.com/staabm/phpstan-todo-by/actions/runs/9227566752/job/25389786214#step:6:26

It seems the failure is related to the CI process rather than changes made in this PR. Maybe it’s some caching issue? Maybe in composer we should require concrete commit hash and not branch name? Unfortunately I’m not that familiar with GitHub actions so I don’t know what exactly went wrong here.

@staabm
Copy link
Owner

staabm commented May 24, 2024

Thanks for checking. I just did a new commit and it is green now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants