Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pystac version, remove some type: ignores, and do some other linting #449

Merged
merged 2 commits into from
Mar 13, 2023

Conversation

gadomski
Copy link
Member

@gadomski gadomski commented Mar 8, 2023

Description:

pystac 1.7.0 made these unnecessary

PR Checklist:

  • Code is formatted
  • Tests pass
  • Changes are added to the CHANGELOG

@gadomski gadomski requested a review from pjhartzell March 8, 2023 12:38
@gadomski gadomski self-assigned this Mar 8, 2023
pystac 1.7.0 made these unnecessary.
@codecov-commenter
Copy link

codecov-commenter commented Mar 8, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.02 ⚠️

Comparison is base (7c6629f) 87.17% compared to head (fc690f5) 87.15%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #449      +/-   ##
==========================================
- Coverage   87.17%   87.15%   -0.02%     
==========================================
  Files          11       11              
  Lines         834      833       -1     
==========================================
- Hits          727      726       -1     
  Misses        107      107              
Impacted Files Coverage Δ
pystac_client/client.py 81.81% <100.00%> (-0.15%) ⬇️
pystac_client/collection_client.py 88.88% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gadomski gadomski changed the title Remove some type: ignores and do some other linting Bump pystac version, remove some type: ignores, and do some other linting Mar 9, 2023
@gadomski gadomski added this to the 0.6.1 milestone Mar 9, 2023
@gadomski gadomski mentioned this pull request Mar 9, 2023
3 tasks
@gadomski gadomski merged commit 646c881 into main Mar 13, 2023
@gadomski gadomski deleted the fix-linting branch March 13, 2023 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants