-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add simple version of get_queryables
#477
Conversation
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #477 +/- ##
==========================================
+ Coverage 87.27% 87.29% +0.02%
==========================================
Files 11 12 +1
Lines 833 858 +25
==========================================
+ Hits 727 749 +22
- Misses 106 109 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, I like the mixin pattern, and StacAPIIO
will give us a nice place to put all href resolution in #480.
Co-authored-by: Pete Gadomski <[email protected]>
Related Issue(s):
Description:
I tried to implement this as a
QueryableMixin
class but the types were convoluted enough that I ended up thinking it was clearer to just put the method on each class.PR Checklist: