Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add simple version of get_queryables #477

Merged
merged 11 commits into from
Apr 21, 2023
Merged

Conversation

jsignell
Copy link
Member

@jsignell jsignell commented Apr 12, 2023

Related Issue(s):

Description:

I tried to implement this as a QueryableMixin class but the types were convoluted enough that I ended up thinking it was clearer to just put the method on each class.

PR Checklist:

  • Code is formatted
  • Tests pass
  • Changes are added to the CHANGELOG

pystac_client/client.py Outdated Show resolved Hide resolved
pystac_client/collection_client.py Outdated Show resolved Hide resolved
@jsignell jsignell requested a review from gadomski April 13, 2023 15:39
@jsignell jsignell self-assigned this Apr 13, 2023
@codecov-commenter
Copy link

codecov-commenter commented Apr 17, 2023

Codecov Report

Patch coverage: 90.74% and project coverage change: +0.02 🎉

Comparison is base (8786fcf) 87.27% compared to head (56fc9b6) 87.29%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #477      +/-   ##
==========================================
+ Coverage   87.27%   87.29%   +0.02%     
==========================================
  Files          11       12       +1     
  Lines         833      858      +25     
==========================================
+ Hits          727      749      +22     
- Misses        106      109       +3     
Impacted Files Coverage Δ
pystac_client/collection_client.py 87.09% <88.00%> (-1.80%) ⬇️
pystac_client/mixins.py 92.00% <92.00%> (ø)
pystac_client/client.py 81.96% <100.00%> (+0.14%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gadomski gadomski added this to the 0.7.0 milestone Apr 17, 2023
pystac_client/mixins.py Outdated Show resolved Hide resolved
Copy link
Member

@gadomski gadomski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, I like the mixin pattern, and StacAPIIO will give us a nice place to put all href resolution in #480.

@jsignell jsignell requested a review from gadomski April 19, 2023 15:09
@gadomski gadomski enabled auto-merge (squash) April 21, 2023 19:48
@gadomski gadomski merged commit 69c3bdf into stac-utils:main Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for fetching catalog queryables
3 participants