Don't transform hrefs in one test

[gadomski]

Related Issue(s):

• Until Object serialization should not make network requests by default #960 is fixed, the default behavior is to hit the network when serializing items.

Description:

We often have intermittent test failures due to an inability to hit CMR, e.g. https://github.com/stac-utils/pystac/actions/runs/4306838650/jobs/7511161952#step:5:321. In this case, the network request is unnecessary for the test that is running, so we diable the network request by setting transform_hrefs=False when serializing items.

I'm sure there's other spots where we could improve things by setting transform_hrefs=False, but rather than do a complete audit, I'd like to fix them as we find them from failed test runs.

PR Checklist:

• Code is formatted (run pre-commit run --all-files)
• Tests pass (run scripts/test)
• Documentation has been updated to reflect changes, if applicable
• This PR maintains or improves overall codebase code coverage.
• Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.30%. Comparing base (d51acae) to head (7ac9291).
Report is 293 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1022   +/-   ##
=======================================
  Coverage   90.30%   90.30%           
=======================================
  Files          47       47           
  Lines        6189     6189           
  Branches      929      929           
=======================================
  Hits         5589     5589           
  Misses        422      422           
  Partials      178      178           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.