Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return all validation issues #1120

Merged
merged 1 commit into from
May 16, 2023

Conversation

ircwaves
Copy link
Member

@ircwaves ircwaves commented May 12, 2023

Related Issue(s):

Description:

Closes #887 by returning all issues found during validation in the source parameter of the STACValidationError

PR Checklist:

  • pre-commit hooks pass locally
  • Tests pass (run scripts/test)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@ircwaves ircwaves requested a review from gadomski May 12, 2023 20:15
@codecov-commenter
Copy link

codecov-commenter commented May 13, 2023

Codecov Report

Patch coverage: 78.94% and project coverage change: +0.01 🎉

Comparison is base (e5efc44) 90.33% compared to head (28e5978) 90.35%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1120      +/-   ##
==========================================
+ Coverage   90.33%   90.35%   +0.01%     
==========================================
  Files          48       48              
  Lines        6343     6343              
  Branches      944      944              
==========================================
+ Hits         5730     5731       +1     
  Misses        431      431              
+ Partials      182      181       -1     
Impacted Files Coverage Δ
pystac/validation/stac_validator.py 79.12% <78.94%> (+1.09%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

pystac/validation/stac_validator.py Show resolved Hide resolved
pystac/validation/stac_validator.py Show resolved Hide resolved
pystac/validation/stac_validator.py Outdated Show resolved Hide resolved
@gadomski
Copy link
Member

Also, needs a CHANGELOG entry.

@gadomski gadomski added this to the 1.8 milestone May 15, 2023
@ircwaves
Copy link
Member Author

Also, needs a CHANGELOG entry.

Yup. Intentional delay of description. 10 ⭐ penalty. Described now.

@ircwaves ircwaves requested a review from gadomski May 16, 2023 11:52
@gadomski gadomski force-pushed the return-all-validation-errors branch from d2e6b67 to 987531c Compare May 16, 2023 12:22
@gadomski gadomski enabled auto-merge May 16, 2023 12:22
@gadomski gadomski added this pull request to the merge queue May 16, 2023
Merged via the queue into stac-utils:main with commit 55ee5f4 May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RFC: Allow validate_all to return all issues with a STAC catalog
3 participants