Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tutorials/example-catalog #1145

Merged
merged 2 commits into from
Jun 6, 2023
Merged

Conversation

jsignell
Copy link
Member

@jsignell jsignell commented Jun 6, 2023

Description:

While running the examples with the new repr, I noticed that this tutorial notebook was broken because it depended on the tutorials/example-catalog which was on a very old version of stac. In the long term it would be good to make the tutorials tell a more cohesive and compelling story, but in the short term I think it makes sense to rework this notebook to depend on the example-catalog contained in the docs dir itself.

PR Checklist:

  • pre-commit hooks pass locally
  • Tests pass (run scripts/test)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (e6d5d75) 91.17% compared to head (3e4edf7) 91.17%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1145   +/-   ##
=======================================
  Coverage   91.17%   91.17%           
=======================================
  Files          49       49           
  Lines        6626     6626           
  Branches      978      978           
=======================================
  Hits         6041     6041           
  Misses        410      410           
  Partials      175      175           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jsignell jsignell marked this pull request as ready for review June 6, 2023 18:05
@jsignell jsignell self-assigned this Jun 6, 2023
@jsignell
Copy link
Member Author

jsignell commented Jun 6, 2023

I don't think this one needs a changelog

@jsignell jsignell requested a review from gadomski June 6, 2023 18:36
@jsignell jsignell added this pull request to the merge queue Jun 6, 2023
Merged via the queue into stac-utils:main with commit 2a7f139 Jun 6, 2023
@jsignell jsignell deleted the example-catalog branch June 6, 2023 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants