Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow more configuration with Catalog.validate_all #1150

Merged
merged 4 commits into from
Jun 7, 2023

Conversation

jsignell
Copy link
Member

@jsignell jsignell commented Jun 7, 2023

Replaces #1141

Related Issue(s):

Description:

I think this covers the scenario described in the original issue of limiting the amount of objects that are iterated over. It made more sense to be to track that as a single number (items + catalogs + collections) and then to separately give a knob for changing whether or no we recurse into the children.

That being said there are lots of ways to tackle this. Anther approach could use a timeout rather than tracking number of objects at all.

PR Checklist:

  • pre-commit hooks pass locally
  • Tests pass (run scripts/test)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@jsignell jsignell requested a review from ircwaves June 7, 2023 17:00
@jsignell jsignell self-assigned this Jun 7, 2023
@jsignell jsignell enabled auto-merge June 7, 2023 17:01
@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01 🎉

Comparison is base (90f45c2) 91.17% compared to head (050da94) 91.18%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1150      +/-   ##
==========================================
+ Coverage   91.17%   91.18%   +0.01%     
==========================================
  Files          49       49              
  Lines        6626     6634       +8     
  Branches      978      980       +2     
==========================================
+ Hits         6041     6049       +8     
  Misses        410      410              
  Partials      175      175              
Impacted Files Coverage Δ
pystac/catalog.py 93.87% <100.00%> (+0.11%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jsignell jsignell added this pull request to the merge queue Jun 7, 2023
Merged via the queue into stac-utils:main with commit 4b1887a Jun 7, 2023
@jsignell jsignell deleted the validate_all branch June 7, 2023 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow more configuration with validate_all
2 participants