Allow more configuration with Catalog.validate_all
#1150
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #1141
Related Issue(s):
Description:
I think this covers the scenario described in the original issue of limiting the amount of objects that are iterated over. It made more sense to be to track that as a single number (items + catalogs + collections) and then to separately give a knob for changing whether or no we recurse into the children.
That being said there are lots of ways to tackle this. Anther approach could use a timeout rather than tracking number of objects at all.
PR Checklist:
pre-commit
hooks pass locallyscripts/test
)