Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add move/copy/delete methods on Asset #1158

Merged
merged 4 commits into from
Jun 13, 2023
Merged

Conversation

jsignell
Copy link
Member

@jsignell jsignell commented Jun 13, 2023

Related Issue(s):

Description:

Add methods to Asset, Item, and Collection to support moving/copying/deleting assets and their referenced data files.

PR Checklist:

  • pre-commit hooks pass locally
  • Tests pass (run scripts/test)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@jsignell jsignell self-assigned this Jun 13, 2023
@jsignell jsignell linked an issue Jun 13, 2023 that may be closed by this pull request
@jsignell jsignell requested a review from gadomski June 13, 2023 17:40
@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.07 🎉

Comparison is base (579a644) 91.99% compared to head (6cd47f7) 92.06%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1158      +/-   ##
==========================================
+ Coverage   91.99%   92.06%   +0.07%     
==========================================
  Files          49       49              
  Lines        6611     6645      +34     
  Branches      978      980       +2     
==========================================
+ Hits         6082     6118      +36     
+ Misses        356      355       -1     
+ Partials      173      172       -1     
Impacted Files Coverage Δ
pystac/asset.py 97.02% <100.00%> (+3.52%) ⬆️
pystac/collection.py 96.19% <100.00%> (+0.07%) ⬆️
pystac/item.py 93.24% <100.00%> (+0.15%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@gadomski gadomski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just needs some doc fixes. The informative error messages and docs are 🤌

pystac/asset.py Show resolved Hide resolved
@jsignell jsignell requested a review from gadomski June 13, 2023 19:21
@gadomski gadomski added this to the 1.8 milestone Jun 13, 2023
@jsignell jsignell added this pull request to the merge queue Jun 13, 2023
Merged via the queue into stac-utils:main with commit 6d59297 Jun 13, 2023
@jsignell jsignell deleted the alter-asset branch June 13, 2023 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RFC: Add move/copy/delete operations for local assets
2 participants