Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow a DeprecationWarning from jsonschema #1187

Merged
merged 1 commit into from
Jul 10, 2023
Merged

Allow a DeprecationWarning from jsonschema #1187

merged 1 commit into from
Jul 10, 2023

Conversation

gadomski
Copy link
Member

@gadomski gadomski commented Jul 7, 2023

Related Issue(s):

Description:

jsonschema v4.18 deprecated RefResolver, so we'll need to update pystac to work around that deprecation. This PR is a quickfix to get CI working, and includes a note about the fix.

Doesn't need a changelog entry.

PR Checklist:

  • pre-commit hooks pass locally
  • Tests pass (run scripts/test)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@gadomski gadomski added this to the 1.8.2 milestone Jul 7, 2023
@gadomski gadomski requested a review from jsignell July 7, 2023 17:54
@gadomski gadomski self-assigned this Jul 7, 2023
jsignell
jsignell approved these changes Jul 10, 2023
View reviewed changes
Copy link
Member

@jsignell jsignell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gadomski gadomski added this pull request to the merge queue Jul 10, 2023
Merged via the queue into main with commit 0e56946 Jul 10, 2023
@gadomski gadomski deleted the ignore-jsonschema-warning branch July 10, 2023 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsignell jsignell jsignell approved these changes

Assignees

@gadomski gadomski

Labels
None yet
Projects
None yet
Milestone
1.8.2
Development

Successfully merging this pull request may close these issues.
2 participants
@gadomski @jsignell