Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyupgrade to 3.9 #1261

Merged
merged 3 commits into from
Oct 12, 2023
Merged

pyupgrade to 3.9 #1261

merged 3 commits into from
Oct 12, 2023

Conversation

gadomski
Copy link
Member

@gadomski gadomski commented Oct 12, 2023

Related Issue(s):

Description:

Applies pyupgrade, and installs a pre-commit rachet to make sure we don't backslide. I don't use a local pre-commit version (like the other hooks) b/c users shouldn't have to have it installed in their environment IMO.

No functional changes, and it's only formatting so no CHANGELOG needed.

PR Checklist:

  • pre-commit hooks pass locally
  • Tests pass (run scripts/test)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@gadomski gadomski requested a review from jsignell October 12, 2023 20:33
@gadomski gadomski self-assigned this Oct 12, 2023
@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Attention: 36 lines in your changes are missing coverage. Please review.

Files Coverage Δ
pystac/__init__.py 94.64% <100.00%> (ø)
pystac/asset.py 97.14% <100.00%> (ø)
pystac/cache.py 92.80% <100.00%> (ø)
pystac/collection.py 93.07% <100.00%> (+0.02%) ⬆️
pystac/common_metadata.py 92.79% <100.00%> (ø)
pystac/errors.py 100.00% <100.00%> (ø)
pystac/extensions/base.py 88.88% <100.00%> (+0.12%) ⬆️
pystac/extensions/classification.py 95.07% <100.00%> (+0.03%) ⬆️
pystac/extensions/ext.py 96.53% <100.00%> (ø)
pystac/extensions/file.py 91.91% <100.00%> (+0.05%) ⬆️
... and 37 more

📢 Thoughts on this report? Let us know!.

.pre-commit-config.yaml Outdated Show resolved Hide resolved
@gadomski gadomski enabled auto-merge October 12, 2023 20:42
@gadomski gadomski added this pull request to the merge queue Oct 12, 2023
Merged via the queue into main with commit e456289 Oct 12, 2023
@gadomski gadomski deleted the issues/1235-pyupgrade-3.9 branch October 12, 2023 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run pyupgrade to get to 3.9
2 participants