Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deprecation messages #1271

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Fix deprecation messages #1271

merged 1 commit into from
Oct 19, 2023

Conversation

gadomski
Copy link
Member

Description:

These things are deprecated in v1.9, not removed then. Doesn't need a CHANGELOG.

PR Checklist:

  • pre-commit hooks pass locally
  • Tests pass (run scripts/test)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@gadomski
fix: deprecation message
a27074d 
These things are deprecated in v1.9, not removed then.
@gadomski gadomski requested a review from jsignell October 19, 2023 14:52
@gadomski gadomski self-assigned this Oct 19, 2023
@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

All modified lines are covered by tests ✅

Files Coverage Δ
pystac/extensions/base.py 88.88% <ø> (ø)

📢 Thoughts on this report? Let us know!.

@gadomski gadomski added this pull request to the merge queue Oct 19, 2023
Merged via the queue into main with commit b40f3be Oct 19, 2023
@gadomski gadomski deleted the fix-deprecation-warnings branch October 19, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsignell jsignell jsignell approved these changes

Assignees

@gadomski gadomski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gadomski @jsignell