Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use the deprecated utcnow #1283

Merged
merged 4 commits into from
Nov 27, 2023

Conversation

avalentino
Copy link
Contributor

Related Issue(s):

Description:

The patch fixes the use of the utcnow method that has been deprecated in Python 3.12.

PR Checklist:

  • pre-commit hooks pass locally
  • Tests pass (run scripts/test)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@gadomski gadomski enabled auto-merge November 27, 2023 13:36
Copy link

codecov bot commented Nov 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c2c1d3c) 91.11% compared to head (f642c89) 91.11%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1283   +/-   ##
=======================================
  Coverage   91.11%   91.11%           
=======================================
  Files          51       51           
  Lines        6986     6986           
  Branches      999      999           
=======================================
  Hits         6365     6365           
  Misses        444      444           
  Partials      177      177           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gadomski gadomski added this pull request to the merge queue Nov 27, 2023
Merged via the queue into stac-utils:main with commit 967ce91 Nov 27, 2023
19 checks passed
@avalentino avalentino deleted the bugfix/fix-deprecations branch November 27, 2023 14:04
@avalentino
Copy link
Contributor Author

Thanks @gadomski

@gadomski
Copy link
Member

Thank you for the contrib!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants