Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs fix: added import for typing objects #1290

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Conversation

tylere
Copy link
Contributor

@tylere tylere commented Dec 6, 2023

Related Issue(s):

  • None

Description:
Currently the code examples use Union and Any without first importing the typing package. This change adds the missing import for 2 code examples.

PR Checklist:

  • pre-commit hooks pass locally
  • Tests pass (run scripts/test)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@gadomski
Copy link
Member

gadomski commented Dec 7, 2023

Thanks for the fix! I wish it were easier to write executable Sphinx docs 😞

@gadomski gadomski enabled auto-merge December 7, 2023 13:32
@gadomski gadomski added this pull request to the merge queue Dec 7, 2023
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (311833f) 91.11% compared to head (f03b15f) 91.11%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1290   +/-   ##
=======================================
  Coverage   91.11%   91.11%           
=======================================
  Files          51       51           
  Lines        6986     6986           
  Branches      999      999           
=======================================
  Hits         6365     6365           
  Misses        444      444           
  Partials      177      177           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Merged via the queue into stac-utils:main with commit 0e6a8e6 Dec 7, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants