add custom validator as input #1320
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1320 +/- ##
=======================================
Coverage 91.18% 91.18%
=======================================
Files 51 51
Lines 7023 7024 +1
Branches 1005 1005
=======================================
+ Hits 6404 6405 +1
Misses 444 444
Partials 175 175 ☔ View full report in Codecov by Sentry. |
|
@jsignell I will look into adding a test. |
| @@ -183,6 +183,55 @@ def test_validates_geojson_with_tuple_coordinates(self) -> None: | |||
| # Should not raise. | |||
| item.validate() | |||
|
|
|||
| @pytest.mark.vcr() | |||
There was a problem hiding this comment.
nice test! If you need vcr then there is probably a cassette file that you need to check in as well. In that case CI will fail. If CI passes then I think you don't need to have pytest.mark.vcr here.
There was a problem hiding this comment.
I am not too familiar with VCR. I assume I need the same references that are contained in data-files/item/sample-item.json ? I simply reused that item from another test case.
There was a problem hiding this comment.
I took a look and it seems like this decorator is good enough. Don't need a new cassette as well.
|
@jsignell |
…ator dependency (relates to stac-utils/pystac#1320)
Related Issue(s):
Description:
Currently, performing validation on STAC objects with extensions that are not directly part of
pystac, or that the schema is not yet published at the expected URI defined by the extension, is not convenient or obvious.In order to call
<STACObject>.validate(), one has to either duplicate the operations done inpystac.validation.validate_dictto use their own validator or set it globally withRegisteredValidator.set_validatorbefore calling<STACObject>.validate(). This PR adds avalidatorinput to all the relevant functions to directly provide the validator to use for validation, with a local reference. This makes it easier to manage the "active" validator at the moment thevalidatemethod gets called.PR Checklist:
pre-commithooks pass locallyscripts/test)