-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove python 3.9 #1384
Merged
Merged
Remove python 3.9 #1384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Numpy ended support Apr 05, 2024
3 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1384 +/- ##
==========================================
+ Coverage 91.07% 91.28% +0.21%
==========================================
Files 51 51
Lines 7070 7220 +150
Branches 1012 1018 +6
==========================================
+ Hits 6439 6591 +152
+ Misses 451 450 -1
+ Partials 180 179 -1 ☔ View full report in Codecov by Sentry. |
jsignell
approved these changes
Aug 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me!
gadomski
added a commit
to stac-utils/pystac-client
that referenced
this pull request
Aug 6, 2024
Following on from stac-utils/pystac#1384
3 tasks
gadomski
added a commit
to stac-utils/pystac-client
that referenced
this pull request
Aug 6, 2024
Following on from stac-utils/pystac#1384
gadomski
added a commit
to stac-utils/pystac-client
that referenced
this pull request
Aug 8, 2024
Following on from stac-utils/pystac#1384
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Numpy ended support Apr 05, 2024. We've done these in MINOR releases in the past, so if https://github.com/stac-utils/pystac/milestone/37 requires a MAJOR we'll want to get a MINOR out w/ this change first, I reckon.
PR Checklist:
pre-commit
hooks pass locallyscripts/test
)