Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set collection to None in item constructor when there is no collection #1400

Merged
merged 2 commits into from
Sep 16, 2024

Conversation

gadomski
Copy link
Member

@gadomski gadomski commented Sep 10, 2024

Related Issue(s):

Description:

collection is listed as a top-level attribute for Item, but it is not set when there is no collection, leading to an attribute error when trying to access Item::collection.

PR Checklist:

  • pre-commit hooks pass locally
  • Tests pass (run scripts/test)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@gadomski gadomski added the bugfix Fixes a bug label Sep 10, 2024
@gadomski gadomski requested a review from jsignell September 10, 2024 22:23
@gadomski gadomski self-assigned this Sep 10, 2024
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.20%. Comparing base (d4bed27) to head (22a78dd).
Report is 34 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1400   +/-   ##
=======================================
  Coverage   91.19%   91.20%           
=======================================
  Files          52       52           
  Lines        7238     7239    +1     
  Branches     1019     1019           
=======================================
+ Hits         6601     6602    +1     
  Misses        457      457           
  Partials      180      180           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gadomski gadomski enabled auto-merge September 11, 2024 15:35
Copy link
Member

@jsignell jsignell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gadomski gadomski added this pull request to the merge queue Sep 16, 2024
Merged via the queue into main with commit 9ffb850 Sep 16, 2024
20 checks passed
@gadomski gadomski deleted the no-collection branch September 16, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants